Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update type imports for core services to types/core #12882

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Apr 18, 2024

Now with the correct chainlink-common and chainlink-solana pins :)

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier
Copy link
Contributor Author

@jmank88 @krehermann This is the corresponding core PR -- I've seen the go.mod conflicts, but going to hold off addressing those until the last minute since I've already had to rebase a few times, and the chainlink-common pin will need to change once again anyway.

go.mod Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Apr 22, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Apr 23, 2024
Merged via the queue into develop with commit 41fea46 Apr 23, 2024
138 of 139 checks passed
@cedric-cordenier cedric-cordenier deleted the move-common-types branch April 23, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants