Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused queryTimeout config from TXM strategy #12859

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

dimriou
Copy link
Collaborator

@dimriou dimriou commented Apr 17, 2024

queryTimeout is a legacy config that was introduced because pruneService wasn't handling timeouts properly. For reference:

Now that the pruneService takes care of that, we can remove it.
This simplifies config extraction PR:

@dimriou dimriou requested review from a team as code owners April 17, 2024 12:58
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

"chainlink": removed
---

Drop unused queryTimeout config from TXM strategy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider the #internal tag since node ops won't care?

Suggested change
Drop unused queryTimeout config from TXM strategy
Drop unused queryTimeout config from TXM strategy #internal

jmank88
jmank88 previously approved these changes Apr 17, 2024
@dimriou dimriou added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 44c9b40 Apr 17, 2024
105 checks passed
@dimriou dimriou deleted the remove_unused_strategy_timeout branch April 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants