-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KS-79] Remote trigger setup #12845
[KS-79] Remote trigger setup #12845
Conversation
bolekk
commented
Apr 16, 2024
•
edited
Loading
edited
- Fully set up a (hardcoded) capability DON in Syncer and move fake Mercury producer over there.
- Refactor remote Aggregator interface to reduce marshaling steps.
- Avoid redundant calls to RegisterTrigger.
- Minor change to Prometheus config in Peer Wrapper.
I see you updated files related to
|
ee1804b
to
5da4534
Compare
5da4534
to
a30bb51
Compare
a30bb51
to
441bfc9
Compare
|
||
agg := remote.NewDefaultModeAggregator(2) | ||
_, err = agg.Aggregate("", [][]byte{marshaled1}) | ||
require.Error(t, err, "failed to aggregate responses, err: not enough identical responses found") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer to make the error a type or var and check with assert/require ErrorIs
rather than string matching.
this approach will also play nicely with wrapping errors via %w
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I'm not sure how to do that and still support wrapped inner errors - do you have an example somewhere?
I also realized that the expected string matching here doesn't actually work that way so I'm removing it.
441bfc9
to
e0ca77b
Compare
1. Fully set up a (hardcoded) capability DON in Syncer and move fake Mercury producer over there. 2. Refactor remote Aggregator interface to reduce marshaling steps. 3. Avoid redundant calls to RegisterTrigger. 4. Minor change to Prometheus config in Peer Wrapper.
e0ca77b
to
04ee0ac
Compare
Quality Gate passedIssues Measures |