Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump grafana/pyroscope-go to 1.1.1 #12412

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Bump grafana/pyroscope-go to 1.1.1 #12412

merged 3 commits into from
Mar 14, 2024

Conversation

poopoothegorilla
Copy link
Contributor

NOTES:

  • was encountering errors when running go test ./... and other commands
  • upgrading to 1.1.1 fixed these errors
# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

@poopoothegorilla poopoothegorilla requested a review from a team as a code owner March 13, 2024 15:49
@poopoothegorilla poopoothegorilla requested review from jmank88 and removed request for a team March 13, 2024 15:49
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@poopoothegorilla poopoothegorilla changed the title Bump grafana to 1.1.1 Bump grafana/pyroscope-go to 1.1.1 Mar 13, 2024
@jmank88 jmank88 requested a review from vyzaldysanchez March 13, 2024 15:58
@jmank88 jmank88 requested a review from patrickhuie19 March 13, 2024 16:00
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Mar 14, 2024
Merged via the queue into develop with commit 83c8688 Mar 14, 2024
118 of 138 checks passed
@prashantkumar1982 prashantkumar1982 deleted the jtw/bump-grafana-1.1.1 branch March 14, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@DylanTinianov DylanTinianov DylanTinianov approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@poopoothegorilla @jmank88 @vyzaldysanchez @patrickhuie19 @DylanTinianov @prashantkumar1982