Skip to content

Commit

Permalink
fix: unused vars
Browse files Browse the repository at this point in the history
  • Loading branch information
KodeyThomas committed Dec 18, 2024
1 parent a0310bf commit fb567e4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pragma solidity ^0.8.19;

import {IFunctionsSubscriptions} from "../v1_0_0/interfaces/IFunctionsSubscriptions.sol";
import {AggregatorV3Interface} from "../../shared/interfaces/AggregatorV3Interface.sol";
import {IFunctionsBilling, FunctionsBillingConfig} from "../v1_0_0/interfaces/IFunctionsBilling.sol";
import {IFunctionsBilling, FunctionsBillingConfig} from "../v1_3_0/interfaces/IFunctionsBilling.sol";

import {Routable} from "../v1_0_0/Routable.sol";
import {FunctionsResponse} from "../v1_0_0/libraries/FunctionsResponse.sol";
Expand Down Expand Up @@ -278,7 +278,6 @@ abstract contract FunctionsBilling is Routable, IFunctionsBilling {
/// @param requestId identifier for the request that was generated by the Registry in the beginBilling commitment
/// @param response response data from DON consensus
/// @param err error from DON consensus
/// @param reportBatchSize the number of fulfillments in the transmitter's report
/// @return result fulfillment result
/// @dev Only callable by a node that has been approved on the Coordinator
/// @dev simulated offchain to determine if sufficient balance is present to fulfill the request
Expand All @@ -287,8 +286,7 @@ abstract contract FunctionsBilling is Routable, IFunctionsBilling {
bytes memory response,
bytes memory err,
bytes memory onchainMetadata,
bytes memory /* offchainMetadata TODO: use in getDonFee() for dynamic billing */,
uint8 reportBatchSize
bytes memory /* offchainMetadata TODO: use in getDonFee() for dynamic billing */
) internal returns (FunctionsResponse.FulfillResult) {
FunctionsResponse.Commitment memory commitment = abi.decode(onchainMetadata, (FunctionsResponse.Commitment));

Expand Down Expand Up @@ -341,7 +339,7 @@ abstract contract FunctionsBilling is Routable, IFunctionsBilling {
emit RequestBilled({
requestId: requestId,
juelsPerGas: juelsPerGas,
l1FeeShareWei: l1FeeShareWei,
l1FeeShareWei: 0,
callbackCostJuels: callbackCostJuels,
donFeeJuels: commitment.donFee,
// The following two lines are because of OperationFee being used in the Offchain Commitment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,7 @@ contract FunctionsCoordinator is OCR2Base, IFunctionsCoordinator, FunctionsBilli
decodedReport.results[i],
decodedReport.errors[i],
decodedReport.onchainMetadata[i],
decodedReport.offchainMetadata[i],
uint8(numberOfFulfillments) // will not exceed "MaxRequestBatchSize" on the Job's ReportingPluginConfig
decodedReport.offchainMetadata[i]
)
);

Expand Down

0 comments on commit fb567e4

Please sign in to comment.