Fix test arbitrum test cases

smartcontractkit · Feb 17, 2023 · 6d5e9bd · 6d5e9bd
1 parent 2c2609e
commit 6d5e9bd
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/chains/evm/gas/arbitrum_estimator_test.go b/core/chains/evm/gas/arbitrum_estimator_test.go
@@ -28,6 +28,7 @@ func TestArbitrumEstimator(t *testing.T) {
 	const maxGasLimit uint32 = 500_000
 	calldata := []byte{0x00, 0x00, 0x01, 0x02, 0x03}
 	const gasLimit uint32 = 80000
+	const gasPriceBufferPercentage = 25
 
 	t.Run("calling GetLegacyGas on unstarted estimator returns error", func(t *testing.T) {
 		config := mocks.NewConfig(t)
@@ -64,7 +65,8 @@ func TestArbitrumEstimator(t *testing.T) {
 		t.Cleanup(func() { assert.NoError(t, o.Close()) })
 		gasPrice, chainSpecificGasLimit, err := o.GetLegacyGas(testutils.Context(t), calldata, gasLimit, maxGasPrice)
 		require.NoError(t, err)
-		assert.Equal(t, assets.NewWeiI(42), gasPrice)
+		// Expected price for a standard l2_suggested_estimator would be 42, but we add a fixed gasPriceBufferPercentage.
+		assert.Equal(t, assets.NewWeiI(42).AddPercentage(gasPriceBufferPercentage), gasPrice)
 		assert.Equal(t, gasLimit, chainSpecificGasLimit)
 	})
 
@@ -185,7 +187,8 @@ func TestArbitrumEstimator(t *testing.T) {
 		gasPrice, chainSpecificGasLimit, err := o.GetLegacyGas(testutils.Context(t), calldata, gasLimit, maxGasPrice)
 		require.NoError(t, err)
 		require.NotNil(t, gasPrice)
-		assert.Equal(t, "42 wei", gasPrice.String())
+		// Again, a normal l2_suggested_estimator would return 42, but arbitrum_estimator adds a buffer.
+		assert.Equal(t, "52 wei", gasPrice.String())
 		assert.Equal(t, expLimit, chainSpecificGasLimit, "expected %d but got %d", expLimit, chainSpecificGasLimit)
 	})