-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container polling speedup, move Promtail to CLI, Delve debugger entrypoint #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
changed the title
Speed up, 7 seconds
Container polling speedup, move Promtail to CLI, Delve debugger entrypoint
Dec 16, 2024
Quality Gate passedIssues Measures |
davidcauchi
pushed a commit
that referenced
this pull request
Dec 18, 2024
…point (#1484) move promtail, speedup, delve
davidcauchi
added a commit
that referenced
this pull request
Dec 18, 2024
* sentinel init * Added sentinel * Fixes * Fix up * Fixup * Cleanup * Fixup * Add block numbers to poll logs * Update version * Remove unneeded functions that were enabling testing * Remove duplication * Hide implementation details * Use CTF logging lib * Update docs * update modgraph * tiny adjustments to Seth docs (#1482) * Keep test outputs for Flakeguard in separate fields (#1485) * Read primary ETH key based on chain id (#1487) * Container polling speedup, move Promtail to CLI, Delve debugger entrypoint (#1484) move promtail, speedup, delve * dlv from flag, fix promtail logs (#1488) * change go doc generation OpenAI api key secret name (#1483) * Enable k8s tests (#1498) --------- Co-authored-by: skudasov <f4hrenh9it@gmail.com> Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com> Co-authored-by: Lukasz <120112546+lukaszcl@users.noreply.github.com> Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the debugging capabilities and operational efficiency of the framework. They simplify and streamline the use of Delve for debugging, improve performance by speeding up container polling, and add flexibility by allowing a debug entrypoint for Delve. The adjustments also include cleanup and optimization across various components, such as moving Promtail to CLI to reduce dependencies and improve maintainability.
What
dlv
debuggers are exposed on specific ports.framework.NewPromtail()
in the observability setup section, simplifying the setup process.framework.NewPromtail()
in theobservabilityUp()
function, ensuring Promtail is initialized correctly during observability setup.