Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container polling speedup, move Promtail to CLI, Delve debugger entrypoint #1484

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Dec 16, 2024

  • Move promtail to CLI
  • Speed up container status polling
  • Add dlv entrypoint with a flag

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the debugging capabilities and operational efficiency of the framework. They simplify and streamline the use of Delve for debugging, improve performance by speeding up container polling, and add flexibility by allowing a debug entrypoint for Delve. The adjustments also include cleanup and optimization across various components, such as moving Promtail to CLI to reduce dependencies and improve maintainability.

What

  • book/src/framework/components/debug.md
    • Removed detailed instructions and examples for setting up Delve manually, simplifying the documentation to mention that all dlv debuggers are exposed on specific ports.
  • framework/.changeset/v0.3.8.md
    • Added a new file summarizing the changes in version 0.3.8, including moving Promtail to CLI, speeding up container polling, and allowing a debug entrypoint for Delve.
  • framework/cmd/interactive.go
    • Removed the call to framework.NewPromtail() in the observability setup section, simplifying the setup process.
  • framework/cmd/observability.go
    • Added a call to framework.NewPromtail() in the observabilityUp() function, ensuring Promtail is initialized correctly during observability setup.
  • framework/components/blockchain/anvil.go, besu.go, geth.go
    • Modified container startup wait conditions to include a poll interval, improving the reliability and performance of blockchain component initializations.
  • framework/components/clnode/clnode.go
    • Enhanced the Chainlink node component to support debugging with Delve, including the addition of a debugger port and a dynamic entry point generation based on environment variables.
  • framework/components/postgres/postgres.go
    • Adjusted the startup wait conditions for the PostgreSQL component, including a poll interval to enhance the initialization process's performance and reliability.
  • framework/components/simple_node_set/node_set.go
    • Extended the simple node set component to allocate and manage Delve debugger ports, facilitating debugging across multiple nodes.
  • framework/components/simple_node_set/nodeset_test.go
    • Updated a test case to reflect the introduction of Delve debugger port management in the simple node set component.
  • framework/config.go
    • Removed the conditional initialization of Promtail based on the environment variable, streamlining the configuration process.
  • framework/examples/myproject/smoke.toml
    • Updated the example configuration to demonstrate the use of Anvil with specific command-line parameters.
  • framework/promtail.go
    • Updated the Promtail initialization function to adjust the default URL and improve the startup timeout, optimizing performance and compatibility with the logging setup.

@skudasov skudasov changed the title Speed up, 7 seconds Container polling speedup, move Promtail to CLI, Delve debugger entrypoint Dec 16, 2024
@skudasov skudasov marked this pull request as ready for review December 16, 2024 17:33
@skudasov skudasov requested review from sebawo and a team as code owners December 16, 2024 17:33
@skudasov skudasov merged commit 88c6d2e into main Dec 16, 2024
45 checks passed
@skudasov skudasov deleted the fund-testnet branch December 16, 2024 17:46
@cl-sonarqube-production
Copy link

davidcauchi pushed a commit that referenced this pull request Dec 18, 2024
davidcauchi added a commit that referenced this pull request Dec 18, 2024
* sentinel init

* Added sentinel

* Fixes

* Fix up

* Fixup

* Cleanup

* Fixup

* Add block numbers to poll logs

* Update version

* Remove unneeded functions that were enabling testing

* Remove duplication

* Hide implementation details

* Use CTF logging lib

* Update docs

* update modgraph

* tiny adjustments to Seth docs (#1482)

* Keep test outputs for Flakeguard in separate fields (#1485)

* Read primary ETH key based on chain id (#1487)

* Container polling speedup, move Promtail to CLI, Delve debugger entrypoint (#1484)

move promtail, speedup, delve

* dlv from flag, fix promtail logs (#1488)

* change go doc generation OpenAI api key secret name (#1483)

* Enable k8s tests (#1498)

---------

Co-authored-by: skudasov <f4hrenh9it@gmail.com>
Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com>
Co-authored-by: Lukasz <120112546+lukaszcl@users.noreply.github.com>
Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant