Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs to files #1396

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Logs to files #1396

merged 11 commits into from
Nov 26, 2024

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Nov 26, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes add an internal IP attribute to the Chainlink node's output, ensuring that any internal communication or identification within a network can utilize this IP. Additionally, it introduces the functionality to write all Docker container logs to a specific directory upon test cleanup, enhancing test diagnostics and debugging capabilities by providing a consolidated location for log review.

What

  • framework/components/clnode/clnode.go
    • Added InternalIP field to the NodeOut struct to store the internal IP address of the Chainlink node container.
    • Implemented logic to fetch and assign the internal IP address of the Chainlink node container to the InternalIP field.
  • framework/config.go
    • Enhanced the test cleanup process to include writing all Docker container logs to a predefined directory, improving debuggability.
  • framework/docker.go
    • Introduced a new constant for the default logs directory.
    • Added a new function WriteAllContainersLogs to write logs of all Docker containers into the default logs directory, facilitating easier access to logs for debugging purposes.

@skudasov skudasov requested review from sebawo and a team as code owners November 26, 2024 19:48
@cl-sonarqube-production
Copy link

@skudasov skudasov merged commit 10612cb into main Nov 26, 2024
44 of 45 checks passed
@skudasov skudasov deleted the logs-to-files branch November 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant