Fix flakeguard aggregate cmds #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
gheorghestrimtu
approved these changes
Nov 18, 2024
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the flexibility and clarity of file paths and messages in the FlakeGuard tool. Setting default paths to empty allows users to specify paths more dynamically, while changing output messages enhances user understanding of the operations performed.
What
aggregate.gotoaggregate_all.goto presumably differentiate it from similar functionalities.results-path,output-results, andoutput-logsflags to be empty or more specific, enhancing user control.results-path,output-results, andoutput-logsflags to be empty or include a specific path, aligning with changes inaggregate_all.go.thresholdandmin-pass-ratioflags, specifying conditions for test failure and flakiness.