-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom port exposure, API credentials override in outputs #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
changed the title
Features
Custom port exposure, API credentials override in outputs
Nov 13, 2024
skudasov
had a problem deploying
to
integration
November 13, 2024 21:12 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:16 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:30 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:34 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:45 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:49 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 21:57 — with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
November 13, 2024 22:01 — with
GitHub Actions
Failure
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clclient.New
signatureBelow is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the flexibility and security of Chainlink nodes in test environments by allowing custom port configurations and setting default API credentials for node authentication. These adjustments facilitate more dynamic testing setups and secure connections to Chainlink nodes.
What
custom_ports
,api_auth_user
, andapi_auth_password
configurations, enabling custom port mappings and default API credentials for Chainlink nodes.api_auth_user
andapi_auth_password
in the example TOML configuration to highlight the capability to set default API credentials for external components.clclient.New
function signature.NewChainlinkClient
function to utilize the new output fields for API credentials, removing hardcoded defaults in favor of configurable options.custom_ports
in node configurations and included default API credentials (api_auth_user
,api_auth_password
) in the node output for secure authentication.NewCLDefaultClients
with the updatedNew
function to align with changes in client initialization, reflecting the shift to configurable API credentials.