Skip to content

Commit

Permalink
turn the tests off until we have access
Browse files Browse the repository at this point in the history
  • Loading branch information
skudasov committed Dec 4, 2024
1 parent 4858447 commit 9406e69
Show file tree
Hide file tree
Showing 2 changed files with 79 additions and 77 deletions.
153 changes: 77 additions & 76 deletions .github/workflows/framework-golden-tests-private.yml
Original file line number Diff line number Diff line change
@@ -1,76 +1,77 @@
name: Framework Golden Tests Examples (Private)
on:
push:

jobs:
test:
defaults:
run:
working-directory: framework/examples/myproject_cll
env:
LOKI_TENANT_ID: promtail
LOKI_URL: http://localhost:3030/loki/api/v1/push
CTF_JD_IMAGE: ${{ secrets.CTF_JD_IMAGE }}
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
strategy:
fail-fast: false
matrix:
test:
- name: TestJD
config: jd.toml
count: 1
timeout: 10m
name: ${{ matrix.test.name }}
steps:
- name: Checkout repo
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- name: Configure AWS credentials using OIDC
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
with:
role-to-assume: ${{ secrets.PUBLIC_AWS_ECR_ROLE }}
aws-region: us-east-1
- name: Authenticate to ECR Public
id: login-ecr-public
uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
with:
registry-type: public
- name: Check for changes in Framework
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
with:
filters: |
src:
- 'framework/**'
- '.github/workflows/framework-golden-tests.yml'
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.22.8
- name: Cache Go modules
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: go-modules-${{ hashFiles('framework/examples/myproject_cll/go.sum') }}-${{ runner.os }}-framework-golden-examples
restore-keys: |
go-modules-${{ runner.os }}-framework-golden-examples
go-modules-${{ runner.os }}
- name: Install dependencies
run: go mod download
- name: Run System Tests
if: steps.changes.outputs.src == 'true'
env:
CTF_CONFIGS: ${{ matrix.test.config }}
run: |
go test -timeout ${{ matrix.test.timeout }} -v -count ${{ matrix.test.count }} -run ${{ matrix.test.name }}
- name: Upload Logs
if: always()
uses: actions/upload-artifact@v3
with:
name: container-logs-${{ matrix.test.name }}
path: framework/examples/myproject_cll/logs
retention-days: 1
# TODO: enable when we'll have access to ECRs

Check failure on line 1 in .github/workflows/framework-golden-tests-private.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/framework-golden-tests-private.yml#L1

workflow is empty [syntax-check]
Raw output
.github/workflows/framework-golden-tests-private.yml:1:1: workflow is empty [syntax-check]
#name: Framework Golden Tests Examples (Private)
#on:
# push:
#
#jobs:
# test:
# defaults:
# run:
# working-directory: framework/examples/myproject_cll
# env:
# LOKI_TENANT_ID: promtail
# LOKI_URL: http://localhost:3030/loki/api/v1/push
# CTF_JD_IMAGE: ${{ secrets.CTF_JD_IMAGE }}
# runs-on: ubuntu-latest
# permissions:
# id-token: write
# contents: read
# strategy:
# fail-fast: false
# matrix:
# test:
# - name: TestJD
# config: jd.toml
# count: 1
# timeout: 10m
# name: ${{ matrix.test.name }}
# steps:
# - name: Checkout repo
# uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
# - name: Configure AWS credentials using OIDC
# uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
# with:
# role-to-assume: ${{ secrets.PUBLIC_AWS_ECR_ROLE }}
# aws-region: us-east-1
# - name: Authenticate to ECR Public
# id: login-ecr-public
# uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
# with:
# registry-type: public
# - name: Check for changes in Framework
# uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
# id: changes
# with:
# filters: |
# src:
# - 'framework/**'
# - '.github/workflows/framework-golden-tests.yml'
# - name: Set up Go
# uses: actions/setup-go@v4
# with:
# go-version: 1.22.8
# - name: Cache Go modules
# uses: actions/cache@v3
# with:
# path: |
# ~/.cache/go-build
# ~/go/pkg/mod
# key: go-modules-${{ hashFiles('framework/examples/myproject_cll/go.sum') }}-${{ runner.os }}-framework-golden-examples
# restore-keys: |
# go-modules-${{ runner.os }}-framework-golden-examples
# go-modules-${{ runner.os }}
# - name: Install dependencies
# run: go mod download
# - name: Run System Tests
# if: steps.changes.outputs.src == 'true'
# env:
# CTF_CONFIGS: ${{ matrix.test.config }}
# run: |
# go test -timeout ${{ matrix.test.timeout }} -v -count ${{ matrix.test.count }} -run ${{ matrix.test.name }}
# - name: Upload Logs
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: container-logs-${{ matrix.test.name }}
# path: framework/examples/myproject_cll/logs
# retention-days: 1
3 changes: 2 additions & 1 deletion framework/components/jd/jd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ import (
// here we only test that we can boot up JD
// client examples are under "examples" dir
// since JD is private this env var should be set locally and in CI
func TestComponentDockerJD(t *testing.T) {
// TODO: add ComponentDocker prefix to turn this on when we'll have access to ECRs
func TestJD(t *testing.T) {
err := framework.DefaultNetwork(&sync.Once{})
require.NoError(t, err)
pgOut, err := postgres.NewPostgreSQL(&postgres.Input{
Expand Down

0 comments on commit 9406e69

Please sign in to comment.