Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiNode Adaptor Managed Subscriptions #960

Open
wants to merge 12 commits into
base: BCFR-1071-Generic-MultiNodeClient
Choose a base branch
from
Open

MultiNode Adaptor Managed Subscriptions #960

wants to merge 12 commits into from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Dec 5, 2024 •
edited
Loading

Description

Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-213

Added a managed subscription which enables the MultiNode Adaptor to remove subscriptions when Unsubscribe() is called.

Soak Test

Namespace: solana-gauntlet-embedded-6c6ca

@DylanTinianov DylanTinianov self-assigned this Dec 5, 2024
@DylanTinianov DylanTinianov changed the title Remove closed subs Remove closed subscriptions Dec 5, 2024
@DylanTinianov DylanTinianov marked this pull request as ready for review December 5, 2024 15:40
@DylanTinianov DylanTinianov requested a review from a team as a code owner December 5, 2024 15:40
@DylanTinianov DylanTinianov changed the title Remove closed subscriptions Remove Subs on Unsubscribe Dec 5, 2024
@DylanTinianov DylanTinianov changed the title Remove Subs on Unsubscribe MultiNode Adaptor Managed Subscriptions Dec 12, 2024
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaidashenko dhaidashenko dhaidashenko requested changes

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanTinianov @dhaidashenko