[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951

Farber98 · 2024-11-28T22:34:06Z

Description

Track transaction statuses on per signature basis to identify which signature for a transaction was included to detect re-orgs specifically for it
Update the confirmation logic to identify regression in a signature’s transaction status when no or processed status is received to detect re-orgs
- A transaction can revert back to no status or processed from confirmed status
- A transaction can revert back to no status from processed status
If a re-org is detected
- from confirmed, restart the retry/bump loop
- from processed, we don't do nothing and it's handled by expiration rebroadcast if needed later

Tickets

Soak Testing

[NONEVM-984][SOAK] - Reorg Detection #969

…ebroadcasted

…nment

silaslenihan · 2025-01-07T22:30:58Z

pkg/solana/txm/pendingtx.go

+	case txmutils.Confirmed:
+		if sigOnChainState == txmutils.Processed || sigOnChainState == txmutils.Broadcasted || sigOnChainState == txmutils.NotFound {


Wouldn't there be a case where the in-memory state differs from the on-chain state due to the chain being polled more recently, which wouldn't be a true reorg?

There's no problem that we have different states as long as the on-chain one is greater or equal than our in-memory one.

If this premise is false, it's because:

A re-org occurred and we need to handle it

Potential Lagging RPC edge case

We are not sure if this is a real risk

#951 (comment)

Yeah this is what I was getting at... I guess you guys have already thought it through though and nothing has come up in soak testing

silaslenihan · 2025-01-07T22:33:07Z

pkg/solana/txm/pendingtx.go

+	if tempTx, confirmedExists = c.confirmedTxs[id]; confirmedExists {
+		tx = tempTx
+	}
+


Shouldn't it be impossible for a tx to exist in both confirmed and broadcasted since it's deleted during OnCofirmed? Not saying this is a huge issue mostly just testing my understanding

Yes, this shouldn't happen. What is your concern about this?

Well this function seems to be okay with that case where broadcastedExists and confirmedExists, I guess the reorg would just be caught elsewhere?

We catch the reorgs here:

When getting a NotFound sig, we check if our in-memory state is higher for it (Processed or Confirmed) and needs to be handled

When getting a Processed signature sig, if our in-memory state is higher for it (Confirmed) and needs to be handled

By definition, no reorgs from Finalized state should happen, that's why they are not handled

pkg/solana/txm/pendingtx.go

pkg/solana/txm/txm.go

jadepark-dev

Amazing work, looks good to me!

cl-sonarqube-production · 2025-01-10T13:16:28Z

Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
77.2% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube

* refactor so txm owns blockhash assignment * lastValidBlockHeight shouldn't be exported * better comment * refactor sendWithRetry to make it clearer * confirm loop refactor * fix infinite loop * move accountID inside msg * lint fix * base58 does not contain lower l * fix hash errors * fix generate random hash * remove blockhash as we only need block height * expired tx changes without tests * add maybe to mocks * expiration tests * send txes through queue * revert pendingtx leakage of information. overwrite blockhash * fix order of confirm loop and not found signature check * fix mocks * prevent confirmation loop to mark tx as errored when it needs to be rebroadcasted * fix test * fix pointer * add comments * reduce rpc calls + refactors * tests + check to save rpc calls * address feedback + remove redundant impl * iface comment * address feedback on compute unit limit and lastValidBlockHeight assignment * blockhash assignment inside txm.sendWithRetry * address feedback * Merge branch 'develop' into nonevm-706-support-custom-bumping-strategy-rpc-expiration-within-confirmation * refactors after merge * fix interactive rebase * fix whitespace diffs * fix import * fix mocks * add on prebroadcaste error * remove rebroadcast count and fix package * improve docs * track status on each signature to detect reorgs * move things arround + add reorg detection * linting errors * fix some state tracking instances * remove redundant sig update * move state from txes to sigs * fix listAllExpiredBroadcastedTxs * handle reorg after confirm cycle * associate sigs to retry ctx * remove unused ctx * add errored state and remove finalized * comment * Revert "comment" This reverts commit 6bc0c62. * Revert "remove unused ctx" This reverts commit 2902ec0. * Revert "associate sigs to retry ctx" This reverts commit 8c18891. * Revert "fix listAllExpiredBroadcastedTxs" This reverts commit f4c6069. * Revert "move state from txes to sigs" This reverts commit 3a6e643. * fix tx state * address feedback * fix ci * fix lint * handle multiple sigs case * improve comment * improve logic and comments * fix comparison against blockHeight instead of slotHeight * address feedback * fix lint * fix log * address feedback * remove useless slot height * address feedback * add comment * tests and fix some bugs * address feedback * address feedback * validate that tx doesn't exist in any of maps when adding new tx * get height instead of whole block optimization * fix mocks on expiration * fix test * rebroadcast with new blockhash + add integration tests * fix integration tests * remove unused params and better comments * handle reorg equally for processed and confirmed at a sig level * add comments and rename txHasReorg to IsTxReorged for better readability * change test name to solve github CI failing check * fix ci * fix tests removing parallel * fix integration tests * capture range var * address feedback * address feedback

Farber98 added 30 commits November 26, 2024 17:30

refactor so txm owns blockhash assignment

2d1a82d

lastValidBlockHeight shouldn't be exported

50dfef0

better comment

4e545e2

refactor sendWithRetry to make it clearer

4ded53c

confirm loop refactor

9e1be6d

fix infinite loop

7dd2028

move accountID inside msg

6c675f2

lint fix

b0d9426

base58 does not contain lower l

1b38665

fix hash errors

6923ddf

fix generate random hash

462844b

remove blockhash as we only need block height

fd785d0

expired tx changes without tests

cf958a4

add maybe to mocks

c5e957b

expiration tests

a505993

send txes through queue

adc8b1c

revert pendingtx leakage of information. overwrite blockhash

7d77f99

fix order of confirm loop and not found signature check

92a280b

fix mocks

2598e19

prevent confirmation loop to mark tx as errored when it needs to be r…

42b3da1

…ebroadcasted

fix test

89af1f3

fix pointer

5e8a0da

add comments

75c1dcd

reduce rpc calls + refactors

4ff2d23

tests + check to save rpc calls

84e423e

address feedback + remove redundant impl

7d8319e

iface comment

68f3a3e

address feedback on compute unit limit and lastValidBlockHeight assig…

780179f

…nment

blockhash assignment inside txm.sendWithRetry

98f0246

address feedback

cbf55f6

Farber98 temporarily deployed to integration January 7, 2025 19:55 — with GitHub Actions Inactive

Farber98 temporarily deployed to integration January 7, 2025 20:00 — with GitHub Actions Inactive

amit-momin approved these changes Jan 7, 2025

View reviewed changes

silaslenihan reviewed Jan 7, 2025

View reviewed changes

pkg/solana/txm/pendingtx.go Show resolved Hide resolved

silaslenihan reviewed Jan 7, 2025

View reviewed changes

pkg/solana/txm/txm.go Show resolved Hide resolved

silaslenihan approved these changes Jan 7, 2025

View reviewed changes

prashantkumar1982 approved these changes Jan 8, 2025

View reviewed changes

Merge branch 'develop' into nonevm-984-reorg

722e377

Farber98 temporarily deployed to integration January 9, 2025 15:15 — with GitHub Actions Inactive

Farber98 temporarily deployed to integration January 9, 2025 15:20 — with GitHub Actions Inactive

jadepark-dev approved these changes Jan 9, 2025

View reviewed changes

Merge branch 'develop' into nonevm-984-reorg

64ce56c

Farber98 had a problem deploying to integration January 9, 2025 23:08 — with GitHub Actions Error

Farber98 temporarily deployed to integration January 9, 2025 23:08 — with GitHub Actions Inactive

Farber98 temporarily deployed to integration January 9, 2025 23:13 — with GitHub Actions Inactive

Farber98 mentioned this pull request Jan 10, 2025

[NONEVM-984] Solana TXM Reorg Detection reference bump smartcontractkit/chainlink#15888

Merged

aalu1418 merged commit e2a9566 into develop Jan 10, 2025
57 of 69 checks passed

aalu1418 deleted the nonevm-984-reorg branch January 10, 2025 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951

[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951

Farber98 commented Nov 28, 2024 •

edited

Loading

silaslenihan Jan 7, 2025

Farber98 Jan 8, 2025 •

edited

Loading

silaslenihan Jan 8, 2025 •

edited

Loading

silaslenihan Jan 7, 2025

Farber98 Jan 8, 2025

silaslenihan Jan 8, 2025

Farber98 Jan 8, 2025

jadepark-dev left a comment

cl-sonarqube-production bot commented Jan 10, 2025

		case txmutils.Confirmed:
		if sigOnChainState == txmutils.Processed \|\| sigOnChainState == txmutils.Broadcasted \|\| sigOnChainState == txmutils.NotFound {

[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951

[NONEVM-984][solana] - Reorg Detection + lighter rpc call #951

Conversation

Farber98 commented Nov 28, 2024 • edited Loading

Description

Tickets

Soak Testing

silaslenihan Jan 7, 2025

Choose a reason for hiding this comment

Farber98 Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

silaslenihan Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

silaslenihan Jan 7, 2025

Choose a reason for hiding this comment

Farber98 Jan 8, 2025

Choose a reason for hiding this comment

silaslenihan Jan 8, 2025

Choose a reason for hiding this comment

Farber98 Jan 8, 2025

Choose a reason for hiding this comment

jadepark-dev left a comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Jan 10, 2025

Quality Gate passed

Farber98 commented Nov 28, 2024 •

edited

Loading

Farber98 Jan 8, 2025 •

edited

Loading

silaslenihan Jan 8, 2025 •

edited

Loading