-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogPoller Boilerplate #950
base: develop
Are you sure you want to change the base?
Conversation
) | ||
|
||
type EventSaver interface { | ||
SaveEvent(evt ProgramEvent) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to accept a slice of events, more like this:
SaveEvent(evt ProgramEvent) error | |
SaveEvents(events []ProgramEvent) error |
But we already have an ORM method that does basically that, so we can probably just use that unless we want to wrap it with some conversion layer:
InsertLogs(logs []Log) error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works. This method is only a placeholder and can use the ORM method instead.
return p | ||
} | ||
|
||
func (p *Service) AddFilter(name string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like RegisterFilter()
we have that implemented and is in review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface for LogPoller (as well as all of the data structures that will be passed between QueryKey & LogPoller) is fully specified in the design doc. In principle, that should be enough for QueryKey to be implemented, and should be considered the source of truth--so I'd recommend starting there, and if there is anything missing or that needs to be updated in light of more recent conversations we can discuss.
9a56419
to
d60fe71
Compare
Quality Gate failedFailed conditions |
basic boilerplate that connects loader to base log poller