Rename job spec 'NodeEndpointRPC' arg as 'NodeEndpointHTTP' #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
force-pushed
the
chore/param-rename
branch
from
7eaf43b to
bc248d2
Compare
krebernisak
commented
Dec 22, 2021
| transmitter types.Account | ||
| } | ||
|
|
||
| func sortOraclesBySigningKey( |
There was a problem hiding this comment.
@aalu1418 this helper fn was unused so I removed it.
There was a problem hiding this comment.
sounds good to me! (looks unused to me as well)
the sorting should occur before gauntlet sees it. and the local testing environment has it's own sort
RodrigoAD
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.