Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous fixes + get local env running again #57

Merged
merged 11 commits into from
Jan 5, 2022
Merged

Miscellaneous fixes + get local env running again #57

merged 11 commits into from
Jan 5, 2022

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Dec 17, 2021 •
edited
Loading

  • Update local testing environment to be compatible with latest gauntlet
  • Remove extra large state log from reading state
  • Log tx sig for debugging
  • Return error in transmit go routine if context not cancelled
    • tested? - to be addressed in separate PR
  • Check against new contract + transmission state Contracts: Allow storing more historical data & refactor validator+proxy into store #74
  • Update job spec parameter from RPC to URL (already done)

@aalu1418 aalu1418 changed the base branch from master to feature/relay December 17, 2021 18:12
@aalu1418 aalu1418 linked an issue Dec 17, 2021 that may be closed by this pull request
Less verbose logging of state #50
Closed
@aalu1418 aalu1418 marked this pull request as ready for review December 17, 2021 20:24
krebernisak
krebernisak reviewed Dec 17, 2021
View reviewed changes
pkg/solana/transmitter.go
context.Background(), // does not use libocr transmit context
c.client.rpc,
c.client.ws,
tx,
true, // skip preflight
rpc.CommitmentConfirmed,
); err != nil {
)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should report this error back to libocr if it happens while libocr context still didn't expire (timeout).

For example, if the SendAndConfirmTra.. errors immediately, we don't actually report these errors upstream, so libocr assumes success while more information is available.

Copy link
Collaborator

@krebernisak krebernisak Dec 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh that's a good point. I'll give it a shot...and see if i can test it too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: this will be done in a separate PR. this PR is now for getting everything working again with recent program changes

@krebernisak krebernisak mentioned this pull request Dec 17, 2021
Closed
@aalu1418 aalu1418 marked this pull request as draft December 17, 2021 23:00
@krebernisak krebernisak changed the base branch from feature/relay to develop December 20, 2021 16:42
@krebernisak krebernisak linked an issue Dec 21, 2021 that may be closed by this pull request
onTransmit report error back to libocr, if error surfaced while the context is still alive #58
Closed
@aalu1418 aalu1418 changed the title Miscellaneous fixes Miscellaneous fixes + get local env running again Jan 5, 2022
@aalu1418 aalu1418 marked this pull request as ready for review January 5, 2022 20:58
topliceanu
topliceanu approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@topliceanu topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/setPayees.ts
}),
)
).every((isValid) => isValid)
this.flags.TESTING_ONLY_IGNORE_PAYEE_VALIDATION &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/setPayees.ts
input.operators.map(async ({ payee }) => {
try {
const info = await token.getAccountInfo(new PublicKey(payee))
return !!info.address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 This is a dangerous cast. Do we know address is a string? Can you make this specific

gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/setPayees.ts
).every((isValid) => isValid)

this.require(
areValidPayees || !!input.allowFundRecipient,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@aalu1418
Copy link
Collaborator Author

aalu1418 commented Jan 5, 2022

@topliceanu thanks for the review! i'll make a note to fix those things. I have ideas to improve some of them

@aalu1418 aalu1418 merged commit 218ff2c into develop Jan 5, 2022
@aalu1418 aalu1418 deleted the misc-updates branch January 5, 2022 21:44
@aalu1418 aalu1418 mentioned this pull request Jan 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krebernisak krebernisak krebernisak left review comments

@topliceanu topliceanu topliceanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aalu1418 @topliceanu @krebernisak