Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain reader and codec #566

Merged
merged 22 commits into from
Jan 22, 2024
Merged

Add chain reader and codec #566

merged 22 commits into from
Jan 22, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Dec 22, 2023 •
edited
Loading

core ref: 119386a71ed260414115aa86cb8ca448f3ca38ae

@nolag nolag mentioned this pull request Dec 22, 2023
Closed
ilija42
ilija42 previously approved these changes Dec 22, 2023
View reviewed changes
reductionista
reductionista previously approved these changes Dec 23, 2023
View reviewed changes
@nolag nolag dismissed stale reviews from reductionista and ilija42 via 6e89103 January 19, 2024 01:50
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

aalu1418
aalu1418 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging + overriding required tests - requires interface changes on the core side to pass
(CI does pass on core)

@aalu1418 aalu1418 merged commit 38444d2 into develop Jan 22, 2024
22 of 24 checks passed
@aalu1418 aalu1418 deleted the BCF-2612-ChainReader-Next branch January 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@reductionista reductionista Awaiting requested review from reductionista

@ilija42 ilija42 Awaiting requested review from ilija42

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolag @jmank88 @reductionista @aalu1418 @ilija42