Fix padWorkflowName()
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
requested changes
Dec 19, 2024
| neededBytes := append(b, make([]byte, 10-len(b))...) | ||
| m.WorkflowName = hex.EncodeToString(neededBytes) | ||
| } else if len(m.WorkflowName) < 10 { | ||
| // Pad with spaces | ||
| suffix := strings.Repeat(" ", 10-len(m.WorkflowName)) |
There was a problem hiding this comment.
This should never be the case. You also don't really have to hex-decode. Just pad with "0" chars up to length 20.
There was a problem hiding this comment.
cc @krehermann - cap_encoder.go in core validates that and fails it it's not a valid hex string that decodes to 10 bytes. We should require it here too.
There was a problem hiding this comment.
ok. if it's got to be that then let's move the validation to this struct. can be a follow up change.
code comments aren't sufficient if there are restrictions on the values. and doesn't make sense to have validation far away in a different repo. @vyzaldysanchez can you do that as a follow up (write a Validate method for this struct)
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
krehermann
reviewed
Dec 19, 2024
| } | ||
|
|
||
| // the contract requires exactly 10 bytes for the workflow name | ||
| // the json schema allows for a variable length string <= len(10) | ||
| // pad with trailing spaces to meet the contract requirements | ||
| // the resulting workflow name should be up to 10 bytes long |
There was a problem hiding this comment.
why did this change? i don't think it's correct
krehermann
approved these changes
Dec 19, 2024
bolekk
approved these changes
Dec 19, 2024
| fields: fields{ | ||
| WorkflowName: "not-hex", | ||
| }, | ||
| want: "not-hex0000000000000", |
There was a problem hiding this comment.
lol, technically correct ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports