-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add registration refresh and expiry to executable capability remote config #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May tests be provided for a new code? Please refer Sonar Quality Gate.
ed33449
to
6e30294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You can probably add some test coverage of new fields in existing tests...?
required for the change to reuse trigger registration logic in executable capabilities -> https://smartcontract-it.atlassian.net/browse/CAPPL-314