Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add registration refresh and expiry to executable capability remote config #968

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ettec
Copy link
Contributor

@ettec ettec commented Dec 10, 2024

required for the change to reuse trigger registration logic in executable capabilities -> https://smartcontract-it.atlassian.net/browse/CAPPL-314

@ettec ettec changed the title wip add registration refresh and expiry to executable capability remote config Dec 10, 2024
@ettec ettec marked this pull request as ready for review December 10, 2024 11:34
@ettec ettec requested review from a team as code owners December 10, 2024 11:34
@ettec ettec requested a review from chudilka1 December 10, 2024 11:34
Copy link
Collaborator

@chudilka1 chudilka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May tests be provided for a new code? Please refer Sonar Quality Gate.

bolekk
bolekk previously approved these changes Dec 17, 2024
Copy link
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can probably add some test coverage of new fields in existing tests...?

@ettec ettec merged commit bbe318c into main Dec 17, 2024
11 checks passed
@ettec ettec deleted the register-to-workflow branch December 17, 2024 12:09
hendoxc pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants