Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPPL-270/271] Fix Consensus bugs #934

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[CAPPL-270/271] Fix Consensus bugs #934

merged 4 commits into from
Nov 13, 2024

Conversation

cedric-cordenier
Copy link
Contributor

  • Fix "result is not a pointer error" in the reduce aggregator
  • Continue rather than error if we encounter an aggregation error

- Fix "result is not a pointer error" in the reduce aggregator
- Continue rather than error if we encounter an aggregation error
@@ -517,22 +582,6 @@ func TestReduceAggregator_Aggregate(t *testing.T) {
return map[commontypes.OracleID][]values.Value{}
},
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because this isn't actually a problem in the current implementation and doesn't error

@@ -339,7 +339,7 @@ func (r *reportingPlugin) Outcome(ctx context.Context, outctx ocr3types.OutcomeC
outcome, err2 := agg.Aggregate(lggr, workflowOutcome, obs, r.config.F)
if err2 != nil {
lggr.Errorw("error aggregating outcome", "error", err2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would make sense to log weid here and all logs above (can be done separately)

@cedric-cordenier cedric-cordenier merged commit cb37b93 into main Nov 13, 2024
10 checks passed
@cedric-cordenier cedric-cordenier deleted the CAPPL-270 branch November 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants