Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get latest value with head data #931

Merged
merged 3 commits into from
Nov 13, 2024
Merged

add get latest value with head data #931

merged 3 commits into from
Nov 13, 2024

Conversation

ettec
Copy link
Contributor

@ettec ettec commented Nov 11, 2024

chainreader common changes required for https://smartcontract-it.atlassian.net/browse/CAPPL-108

@ettec ettec marked this pull request as ready for review November 13, 2024 09:54
@ettec ettec requested a review from a team as a code owner November 13, 2024 09:54
@ettec ettec requested review from pavel-raykov and removed request for a team November 13, 2024 09:54
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have more tests. For e.g. a test that checks how different condfidence levels passed into the method affect the returned headData.

@ettec ettec merged commit ad26f60 into main Nov 13, 2024
10 of 11 checks passed
@ettec ettec deleted the rc-chainreader branch November 13, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants