Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes required for remote action support #930

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Changes required for remote action support #930

merged 3 commits into from
Nov 14, 2024

Conversation

ettec
Copy link
Contributor

@ettec ettec commented Nov 11, 2024 •
edited
Loading

Changes required for remote action support as part of -> https://smartcontract-it.atlassian.net/browse/CAPPL-108

@ettec ettec force-pushed the contract-reader-loop-fix branch from 5631f01 to 38cd8cb Compare November 11, 2024 10:20
@ettec ettec force-pushed the contract-reader-loop-fix branch from 38cd8cb to 4ab0a1f Compare November 11, 2024 15:11
@ettec ettec force-pushed the contract-reader-loop-fix branch from 4ab0a1f to a318690 Compare November 13, 2024 15:32
@ettec ettec marked this pull request as ready for review November 13, 2024 15:41
@ettec ettec requested review from a team as code owners November 13, 2024 15:41
@ettec ettec requested review from krehermann and removed request for a team November 13, 2024 15:41
@ettec ettec changed the title Contract reader loop fix Changes required for remote action support Nov 13, 2024
krehermann
krehermann previously approved these changes Nov 13, 2024
View reviewed changes
pkg/capabilities/capabilities.go Outdated Show resolved Hide resolved
pkg/capabilities/pb/capabilities_helpers.go Outdated Show resolved Hide resolved
@ettec ettec force-pushed the contract-reader-loop-fix branch from 112f5d0 to 9d21731 Compare November 14, 2024 11:08
@ettec ettec force-pushed the contract-reader-loop-fix branch from 9d21731 to 905f821 Compare November 14, 2024 12:33
@ettec ettec merged commit aadff98 into main Nov 14, 2024
10 of 11 checks passed
@ettec ettec deleted the contract-reader-loop-fix branch November 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@george-dorin george-dorin george-dorin approved these changes

@ilija42 ilija42 ilija42 approved these changes

@krehermann krehermann krehermann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ettec @krehermann @cedric-cordenier @ilija42 @george-dorin