Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codec wrapper modifier #905

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Add codec wrapper modifier #905

merged 5 commits into from
Nov 5, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Oct 30, 2024

Requires

Supports

@ilija42 ilija42 marked this pull request as ready for review November 1, 2024 14:21
@ilija42 ilija42 requested review from nolag, pablolagreca and a team as code owners November 1, 2024 14:21
@ilija42 ilija42 requested review from reductionista and removed request for a team November 1, 2024 14:21
mateusz-sekara
mateusz-sekara previously approved these changes Nov 4, 2024
Copy link
Collaborator

@mateusz-sekara mateusz-sekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough knowledge about chain reader and its concepts to review it from the functional perspective. High level looks good to me, how would the config for the ccip case (BigInt) look like?

pkg/codec/config.go Outdated Show resolved Hide resolved
@ilija42
Copy link
Contributor Author

ilija42 commented Nov 4, 2024

I don't have enough knowledge about chain reader and its concepts to review it from the functional perspective. High level looks good to me, how would the config for the ccip case (BigInt) look like?

The config for MsgsBetweenSeqNums would have to add this

&codec.WrapperModifierConfig{
			Fields: map[string]string{
			         "FeeToken":       "Int",
				 "FeeTokenAmount": "Int"},
			}

@ilija42 ilija42 merged commit 15c5bee into main Nov 5, 2024
11 of 12 checks passed
@ilija42 ilija42 deleted the wrapper-modifier branch November 5, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants