[cappl-86] feat(workflows/wasm): emit msgs to beholder #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStreet3
had a problem deploying
to
integration
GitHub Actions
Failure
MStreet3
force-pushed
the
cappl-86/emit-msgs-beholder
branch
from
f2c258b to
29271ca
Compare
MStreet3
had a problem deploying
to
integration
GitHub Actions
Failure
MStreet3
had a problem deploying
to
integration
GitHub Actions
Failure
MStreet3
force-pushed
the
cappl-86/emit-msgs-beholder
branch
from
4d20e25 to
f304f4d
Compare
MStreet3
had a problem deploying
to
integration
GitHub Actions
Failure
MStreet3
force-pushed
the
cappl-86/emit-msgs-beholder
branch
from
f304f4d to
0f6ea6b
Compare
MStreet3
had a problem deploying
to
integration
GitHub Actions
Failure
agparadiso
reviewed
Oct 15, 2024
MStreet3
force-pushed
the
cappl-86/emit-msgs-beholder
branch
from
0f6ea6b to
9cc6e69
Compare
MStreet3
dismissed stale reviews from patrickhuie19, cedric-cordenier, and agparadiso
via
5f29a10
MStreet3
force-pushed
the
cappl-86/emit-msgs-beholder
branch
from
efec9c8 to
5f29a10
Compare
MStreet3
requested review from
patrickhuie19,
agparadiso and
cedric-cordenier
patrickhuie19
previously approved these changes
Oct 22, 2024
MStreet3
commented
Oct 22, 2024
agparadiso
approved these changes
Oct 22, 2024
cedric-cordenier
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new method
Emitter() MessageEmitterin the wasm SDK, which returns an emitter that sends custom messages to an external collector. TheEmitter()method is exposed on the guestRuntimefor custom compute.To implement
MessageEmitter, thewasip1build now links and exposes a new function calledemit. Thewasip1host implementation ofemitdepends on a separateMessageEmitterwhich is passed via the module config. The passedMessageEmitteris typically an instance of anevents.Labeler.All custom compute requests that emit are required to include the
workflow_id,workflow_nameandworkflow_owner_addressor else module requests for compute will fail.Out of Scope
This PR does not address the need for the host's emit behavior to be context aware. Follow up work will handle context within the WASM.