[fix] Handle negative big ints correctly #560
Merged
+176
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
Jun 5, 2024
bolekk
reviewed
Jun 6, 2024
cedric-cordenier
force-pushed
the
handle-negative-big-ints
branch
from
0292bb6 to
1f37dda
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Jun 6, 2024
| @@ -13,10 +14,15 @@ message Value { | |||
| List list_value = 5; | |||
| string decimal_value = 6; | |||
| int64 int64_value = 7; | |||
| bytes bigint_value = 8; | |||
There was a problem hiding this comment.
I think there is a formal way to reserve or deprecate this field
There was a problem hiding this comment.
There was a problem hiding this comment.
I added that on line 8 or did you have something else in mind?
There was a problem hiding this comment.
Oh I just expected it to be inline here inside of the oneof - does it matter?
There was a problem hiding this comment.
These is also this option:
bytes bigint_value = 8 [deprecated = true];
krehermann
approved these changes
Jun 6, 2024
bolekk
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.