fix(observability-lib): updating alert rules + deleting associated al…

…erts when deleting dashboard

observability-lib/grafana/dashboard.go

@@ -43,7 +43,7 @@ type DeployOptions struct {
 
 func alertRuleExist(alerts []alerting.Rule, alert alerting.Rule) bool {
 	for _, a := range alerts {
-		if reflect.DeepEqual(a, alert) {
+		if reflect.DeepEqual(a.Title, alert.Title) {
 			return true
 		}
 	}
@@ -212,6 +212,19 @@ func DeleteDashboard(options *DeleteOptions) error {
 		return errGetDashboard
 	}
 
+	alertsRule, errGetAlertRules := grafanaClient.GetAlertRulesByDashboardUID(*db.UID)
+	if errGetAlertRules != nil {
+		return errGetAlertRules
+	}
+
+	// delete existing alert rules for the dashboard if alerts are disabled
+	for _, rule := range alertsRule {
+		_, _, errDeleteAlertRule := grafanaClient.DeleteAlertRule(*rule.Uid)
+		if errDeleteAlertRule != nil {
+			return errDeleteAlertRule
+		}
+	}
+
 	_, errDelete := grafanaClient.DeleteDashboardByUID(*db.UID)
 	if errDelete != nil {
 		return errDelete