Remove ShouldAcceptFinalizedReport

It is not used in OCR3
smartcontractkit · Sep 29, 2023 · 68b0f8e · 68b0f8e
1 parent 8550f24
commit 68b0f8e
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 87 deletions.
diff --git a/pkg/reportingplugins/mercury/v1/mercury.go b/pkg/reportingplugins/mercury/v1/mercury.go
@@ -379,35 +379,6 @@ func (rp *reportingPlugin) validateReport(rf ReportFields) error {
 	)
 }
 
-func (rp *reportingPlugin) ShouldAcceptFinalizedReport(ctx context.Context, repts types.ReportTimestamp, report types.Report) (bool, error) {
-	reportEpochRound := mercury.EpochRound{Epoch: repts.Epoch, Round: repts.Round}
-	if !rp.latestAcceptedEpochRound.Less(reportEpochRound) {
-		rp.logger.Debugw("ShouldAcceptFinalizedReport() = false, report is stale",
-			"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-			"reportEpochRound", reportEpochRound,
-		)
-		return false, nil
-	}
-
-	if !(len(report) <= rp.maxReportLength) {
-		rp.logger.Warnw("report violates MaxReportLength limit set by ReportCodec",
-			"reportEpochRound", reportEpochRound,
-			"reportLength", len(report),
-			"maxReportLength", rp.maxReportLength,
-		)
-		return false, nil
-	}
-
-	rp.logger.Debugw("ShouldAcceptFinalizedReport() = true",
-		"reportEpochRound", reportEpochRound,
-		"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-	)
-
-	rp.latestAcceptedEpochRound = reportEpochRound
-
-	return true, nil
-}
-
 func (rp *reportingPlugin) ShouldTransmitAcceptedReport(ctx context.Context, repts types.ReportTimestamp, report types.Report) (bool, error) {
 	return true, nil
 }

diff --git a/pkg/reportingplugins/mercury/v2/mercury.go b/pkg/reportingplugins/mercury/v2/mercury.go
@@ -379,35 +379,6 @@ func (rp *reportingPlugin) validateReport(rf ReportFields) error {
 	)
 }
 
-func (rp *reportingPlugin) ShouldAcceptFinalizedReport(ctx context.Context, repts ocrtypes.ReportTimestamp, report ocrtypes.Report) (bool, error) {
-	reportEpochRound := mercury.EpochRound{Epoch: repts.Epoch, Round: repts.Round}
-	if !rp.latestAcceptedEpochRound.Less(reportEpochRound) {
-		rp.logger.Debugw("ShouldAcceptFinalizedReport() = false, report is stale",
-			"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-			"reportEpochRound", reportEpochRound,
-		)
-		return false, nil
-	}
-
-	if !(len(report) <= rp.maxReportLength) {
-		rp.logger.Warnw("report violates MaxReportLength limit set by ReportCodec",
-			"reportEpochRound", reportEpochRound,
-			"reportLength", len(report),
-			"maxReportLength", rp.maxReportLength,
-		)
-		return false, nil
-	}
-
-	rp.logger.Debugw("ShouldAcceptFinalizedReport() = true",
-		"reportEpochRound", reportEpochRound,
-		"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-	)
-
-	rp.latestAcceptedEpochRound = reportEpochRound
-
-	return true, nil
-}
-
 func (rp *reportingPlugin) ShouldTransmitAcceptedReport(ctx context.Context, repts ocrtypes.ReportTimestamp, report ocrtypes.Report) (bool, error) {
 	return true, nil
 }

diff --git a/pkg/reportingplugins/mercury/v3/mercury.go b/pkg/reportingplugins/mercury/v3/mercury.go
@@ -422,35 +422,6 @@ func (rp *reportingPlugin) validateReport(rf ReportFields) error {
 	)
 }
 
-func (rp *reportingPlugin) ShouldAcceptFinalizedReport(ctx context.Context, repts ocrtypes.ReportTimestamp, report ocrtypes.Report) (bool, error) {
-	reportEpochRound := mercury.EpochRound{Epoch: repts.Epoch, Round: repts.Round}
-	if !rp.latestAcceptedEpochRound.Less(reportEpochRound) {
-		rp.logger.Debugw("ShouldAcceptFinalizedReport() = false, report is stale",
-			"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-			"reportEpochRound", reportEpochRound,
-		)
-		return false, nil
-	}
-
-	if !(len(report) <= rp.maxReportLength) {
-		rp.logger.Warnw("report violates MaxReportLength limit set by ReportCodec",
-			"reportEpochRound", reportEpochRound,
-			"reportLength", len(report),
-			"maxReportLength", rp.maxReportLength,
-		)
-		return false, nil
-	}
-
-	rp.logger.Debugw("ShouldAcceptFinalizedReport() = true",
-		"reportEpochRound", reportEpochRound,
-		"latestAcceptedEpochRound", rp.latestAcceptedEpochRound,
-	)
-
-	rp.latestAcceptedEpochRound = reportEpochRound
-
-	return true, nil
-}
-
 func (rp *reportingPlugin) ShouldTransmitAcceptedReport(ctx context.Context, repts ocrtypes.ReportTimestamp, report ocrtypes.Report) (bool, error) {
 	return true, nil
 }