Linting

smartcontractkit · Oct 10, 2024 · 3cf5d9f · 3cf5d9f
1 parent ef71d0f
commit 3cf5d9f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/pkg/capabilities/consensus/ocr3/reporting_plugin.go b/pkg/capabilities/consensus/ocr3/reporting_plugin.go
@@ -365,11 +365,12 @@ func (r *reportingPlugin) Outcome(ctx context.Context, outctx ocr3types.OutcomeC
 				encoderCfg, ok := shaToEncoder[sha]
 				if !ok {
 					lggr.Debugw("could not find encoder matching sha")
-				} else {
-					lggr.Debugw("consensus reached on overridden encoder", "encoderName", encoderCfg.name)
-					encCfg = &encoderCfg
-					break
+					continue
 				}
+
+				lggr.Debugw("consensus reached on overridden encoder", "encoderName", encoderCfg.name)
+				encCfg = &encoderCfg
+				break
 			}
 		}
 

diff --git a/pkg/capabilities/consensus/ocr3/reporting_plugin_test.go b/pkg/capabilities/consensus/ocr3/reporting_plugin_test.go
@@ -946,6 +946,7 @@ func TestReportPlugin_Outcome_ShouldReturnOverriddenEncoder(t *testing.T) {
 
 	assert.Equal(t, opb1.Outcomes[workflowTestID].EncoderName, "evm")
 	ec, err := values.FromMapValueProto(opb1.Outcomes[workflowTestID].EncoderConfig)
+	require.NoError(t, err)
 	assert.Equal(t, ec, m)
 
 	// No consensus on outcome 2