address comments

smartcontractkit · Jun 18, 2024 · 3582847 · 3582847
1 parent c01deaf
commit 3582847
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pkg/loop/internal/relayer/pluginprovider/chainreader/chain_reader_test.go b/pkg/loop/internal/relayer/pluginprovider/chainreader/chain_reader_test.go
@@ -66,7 +66,7 @@ func TestVersionedBytesFunctions(t *testing.T) {
 func TestChainReaderInterfaceTests(t *testing.T) {
 	t.Parallel()
 
-	chainreadertest.LoopEncodingTestMatrix(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
+	chainreadertest.TestAllEncodings(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Parallel()
 
@@ -85,7 +85,7 @@ func TestChainReaderInterfaceTests(t *testing.T) {
 func TestBind(t *testing.T) {
 	t.Parallel()
 
-	chainreadertest.LoopEncodingTestMatrix(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
+	chainreadertest.TestAllEncodings(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Parallel()
 
@@ -113,7 +113,7 @@ func TestBind(t *testing.T) {
 func TestGetLatestValue(t *testing.T) {
 	t.Parallel()
 
-	chainreadertest.LoopEncodingTestMatrix(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
+	chainreadertest.TestAllEncodings(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Parallel()
 
@@ -162,7 +162,7 @@ func TestGetLatestValue(t *testing.T) {
 func TestQueryKey(t *testing.T) {
 	t.Parallel()
 
-	chainreadertest.LoopEncodingTestMatrix(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
+	chainreadertest.TestAllEncodings(t, func(version chainreader.EncodingVersion) func(t *testing.T) {
 		return func(t *testing.T) {
 			t.Parallel()
 
@@ -177,7 +177,6 @@ func TestQueryKey(t *testing.T) {
 			chainReader := errTester.GetChainReader(t)
 
 			t.Run("nil reader should return unimplemented", func(t *testing.T) {
-				t.Parallel()
 				ctx := tests.Context(t)
 
 				nilTester := chainreadertest.WrapChainReaderTesterForLoop(&fakeChainReaderInterfaceTester{impl: nil})

diff --git a/pkg/loop/internal/relayer/pluginprovider/chainreader/test/chain_reader_loop_tester.go b/pkg/loop/internal/relayer/pluginprovider/chainreader/test/chain_reader_loop_tester.go
@@ -12,7 +12,7 @@ import (
 	. "github.com/smartcontractkit/chainlink-common/pkg/types/interfacetests" //nolint common practice to import test mods with .
 )
 
-func LoopEncodingTestMatrix(t *testing.T, test func(chainreader.EncodingVersion) func(t *testing.T)) {
+func TestAllEncodings(t *testing.T, test func(chainreader.EncodingVersion) func(t *testing.T)) {
 	t.Helper()
 
 	encodings := []struct {