Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove completed discovery TODOs. #395

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Remove completed discovery TODOs. #395

merged 4 commits into from
Jan 7, 2025

Conversation

winder
Copy link
Contributor

@winder winder commented Dec 19, 2024

These TODOs refer to "allChains" which was replaced by the "OffRampGetAllSourceChainConfigs" on-chain function.

@winder winder marked this pull request as ready for review December 19, 2024 20:55
@winder winder requested a review from a team as a code owner December 19, 2024 20:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Metric will/discovery-todos main
Coverage 76.5% 76.4%

@winder winder merged commit 34ecb31 into main Jan 7, 2025
17 checks passed
@winder winder deleted the will/discovery-todos branch January 7, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@asoliman92 asoliman92 asoliman92 approved these changes

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winder @asoliman92 @mateusz-sekara