.github/workflows: specify core ref in PR desc #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
requested review from
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
fix test directory for TestAddChainInbound
|
| In order to keep the `ccip-develop` branch in working condition, we need to make sure the integration test | ||
| [written in the CCIP repo](https://github.com/smartcontractkit/ccip/blob/03ae3bbed0e6020be5fa9be26d03af21f152d7dc/core/capabilities/ccip/ccip_integration_tests/ocr3_node_test.go#L37) | ||
| In order to keep the `main` branch in working condition, we need to make sure the integration tests | ||
| [written in the CCIP repo](https://github.com/smartcontractkit/chainlink/blob/340a6bfdf54745dd1c6d9f322d9c9515c97060bb/deployment/ccip/changeset/initial_deploy_test.go#L19) |
There was a problem hiding this comment.
Wait, we run only this single test? It doesn't seem correct, does it? I think as part of this CI action we run every e2e/integration test for ccip 1.6 we have in the chainlink repository. Especially now, when putting more effort to work on these
There was a problem hiding this comment.
Yeah we need to rethink these, maybe as a matrix so we can parallelize
mateusz-sekara
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: 3b6aacef0c21beca9387b192ce016b5ab6168e46
JIRA: https://smartcontract-it.atlassian.net/browse/CCIP-4181
This PR implements something that has been done in the relayer repos, which is that the author of a PR can specify the commit SHA to use for the Chainlink repo when running the integration tests.
Updated the README.md to reflect the new flow.
Also updated the path of the TestAddChainInbound test, previously that step was not running anything.
After running this flow for a few weeks and seeing it work we can then make the integration tests check required for all PRs to merge.