Adding support for RMNRemote discovery #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
reviewed
Sep 26, 2024
Test Coverage
|
makramkd
reviewed
Sep 27, 2024
| @@ -655,7 +658,7 @@ func (r *ccipChainReader) getOfframpStaticConfig( | |||
| //nolint:lll // It's a URL. | |||
| type offrampStaticChainConfig struct { | |||
| ChainSelector cciptypes.ChainSelector `json:"chainSelector"` | |||
| RmnProxy []byte `json:"rmnProxy"` | |||
| Rmn []byte `json:"rmn"` | |||
There was a problem hiding this comment.
Hmm tests seem to be failing after this change, maybe i was wrong?
There was a problem hiding this comment.
The RMNRemote contract is not defined in the dest chain reader defintion. This PR should fix it: smartcontractkit/chainlink#14588
makramkd
reviewed
Sep 27, 2024
makramkd
approved these changes
Sep 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the RMNRemote address from the offramp contract in the dest chain using the discovery processor