feat: add selector immutability checks #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Selector Immutability has been violated ❌ Existing # Testnets
31:
selector: 8953668971247136128
name: "bitcoin-testnet-rootstock" |
|
Selector Immutability has been violated ❌ Existing 57054:
selector: 3676871237479449268
name: "sonic-testnet-blaze" |
andrevmatos
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in immutability checks for
chain-selectors.It's a simple GHA that checks out the previous ref and the current ref and ensures selectors are not modified. Decided to just use yq here, nothing fancy.