Tag evm only get selector as deprecated #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to deprecate-evm-only-get-selector
krehermann
approved these changes
Nov 21, 2024
krehermann
requested changes
Nov 21, 2024
krehermann
approved these changes
Nov 21, 2024
connorwstein
approved these changes
Nov 21, 2024
| @@ -69,6 +69,7 @@ func EvmChainIdToChainSelector() map[uint64]uint64 { | |||
| return copyMap | |||
| } | |||
|
|
|||
| // Deprecated, this only supports EVM chains, use the chain agnostic `GetChainIDFromSelector` instead | |||
There was a problem hiding this comment.
hm are we sure we want to direct to that and not some new EVMChainIdFromSelector which does have the uint64 typing? I think if ChainIdFromSelector was used in an EVM specific context (say in the EVM relayer) it'd be annoying to have to strconv
There was a problem hiding this comment.
in that case I guess users can still rely on the evm specific getter. That's why I think it will be important to at some point create submodules for all these methods, to make the switch explicit.
I'm going to move forward with the merge, however I'm happy to continue this topic in slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag the
ChainIdFromSelectormethod as deprecated since it only supports evm chains, and we are expanding support to non evm.If needed, people can still use it and we don't immediately need to migrate away from it.
If someone needs to also validate that a given chain is evm, they can also use the
GetSelectorFamilywith the same selector.