Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: link to pkg.go.dev docs #75

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

README.md: link to pkg.go.dev docs #75

wants to merge 4 commits into from

Conversation

jmank88
Copy link

@jmank88 jmank88 commented Nov 12, 2024 •
edited
Loading

It looks like some of the generated headers are coming through as package docs:
image

@jmank88 jmank88 requested review from a team as code owners November 12, 2024 18:52
cgruber
cgruber approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@cgruber cgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs branch sync, but this is good.

@jmank88 jmank88 requested a review from a team as a code owner November 26, 2024 13:18
@jmank88 jmank88 requested a review from connorwstein November 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgruber cgruber cgruber approved these changes

@connorwstein connorwstein Awaiting requested review from connorwstein

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @cgruber