Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chaintype.ChainZircuit to chaintypes with rollup support #1596

Closed
wants to merge 1 commit into from
Closed

Add chaintype.ChainZircuit to chaintypes with rollup support #1596

wants to merge 1 commit into from

Conversation

ogtownsend
Copy link
Collaborator

Motivation

  • Zircuit's chaintype was recently changed from optimismBedrock to zircuit
  • This means IsRollupWithL1Support() started returning false for zircuit
  • Which in turn meant no L1 oracle was created for Zircuit

Solution

  • Add zircuit to supportedChainTypes

@ogtownsend ogtownsend requested a review from a team as a code owner January 14, 2025 01:20
@ogtownsend ogtownsend requested a review from matYang January 14, 2025 04:45
@matYang
Copy link
Collaborator

matYang commented Jan 14, 2025

this is core change, given we won't make another release from ccip repo, let's apply this directly in the core repo

@ogtownsend
Copy link
Collaborator Author

will apply this in the core repo

@ogtownsend ogtownsend closed this Jan 14, 2025
@ogtownsend
Copy link
Collaborator Author

smartcontractkit/chainlink#15913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matYang matYang Awaiting requested review from matYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogtownsend @matYang