Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BurnWithFromMintTokenPoolAndProxy #1287

Merged
merged 2 commits into from
Aug 15, 2024
Merged

add BurnWithFromMintTokenPoolAndProxy #1287

merged 2 commits into from
Aug 15, 2024

Conversation

RensR
Copy link
Collaborator

@RensR RensR commented Aug 12, 2024

There's already 1.4 pools out there of this type so we need a proxy

@RensR RensR requested review from makramkd, elatoskinas, RayXpub and a team as code owners August 12, 2024 15:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

LCOV of commit 09e8e5b during Solidity Foundry #7255

Summary coverage rate:
  lines......: 98.7% (1894 of 1919 lines)
  functions..: 96.4% (349 of 362 functions)
  branches...: 90.4% (799 of 884 branches)

Files changed coverage rate: n/a

@RensR RensR force-pushed the add-burnWithFrom-proxy branch from b8781b7 to f972e04 Compare August 12, 2024 15:31
@RensR
Merge branch 'ccip-develop' into add-burnWithFrom-proxy
09e8e5b 
# Conflicts:
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@RensR RensR force-pushed the add-burnWithFrom-proxy branch from 5cf5f49 to 09e8e5b Compare August 15, 2024 12:34
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RensR RensR merged commit 7a0b7f8 into ccip-develop Aug 15, 2024
109 of 110 checks passed
@RensR RensR deleted the add-burnWithFrom-proxy branch August 15, 2024 13:11
dhaidashenko pushed a commit that referenced this pull request Sep 2, 2024
@RensR @asoliman92
add BurnWithFromMintTokenPoolAndProxy (#1287)
5a94c90 
There's already 1.4 pools out there of this type so we need a proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@matYang matYang matYang approved these changes

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RensR @matYang @makramkd