Removing the JWT ENV variable and output parameter #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njegosrailic
changed the title
erikburt
approved these changes
Dec 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See title.
Why
We no longer use this ENV/output since we fetch the token dynamically, and it is used only for the K8s API proxy.
https://github.com/smartcontractkit/.github/blob/main/actions/setup-gap/envoy.yaml.template#L67
For other services, it needs to be fetched from GitHub OIDC, and this needs to be implemented on the application side.
I forgot to clean that up here: #727