Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: go conditional tests #709

Merged
merged 13 commits into from
Dec 6, 2024
Merged

action: go conditional tests #709

merged 13 commits into from
Dec 6, 2024

Conversation

erikburt
Copy link
Contributor

@erikburt erikburt commented Nov 16, 2024 •
edited
Loading

Adds a nodejs action designed to conditionally run unit tests. It does this by:

  1. Building all test binaries
  2. Hashing all test binaries
  3. Comparing the hash of the recently built test binaries, to that of a source-of-truth
  4. Run only the test binaries who's hashes have changed

See README for more information.

RE-3168

@erikburt erikburt self-assigned this Nov 16, 2024
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch 29 times, most recently from 5fba4f9 to be1db7e Compare November 21, 2024 17:57
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from 715026b to ea97eb4 Compare November 28, 2024 21:12
@erikburt erikburt changed the title poc: go test caching action go test runner with caching Nov 28, 2024
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from ea97eb4 to f9eb3c9 Compare November 28, 2024 21:15
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from f9eb3c9 to 6e75459 Compare November 28, 2024 21:42
@erikburt erikburt marked this pull request as ready for review November 28, 2024 21:43
@erikburt erikburt requested a review from a team as a code owner November 28, 2024 21:43
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from ee3fcff to da78aee Compare November 29, 2024 23:19
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from 1ef883c to 04f4267 Compare December 5, 2024 20:40
@erikburt erikburt changed the title go test runner with caching action: go conditional tests Dec 5, 2024
@erikburt erikburt force-pushed the feat/go-test-binary-comparison branch from 04f4267 to e3c8c56 Compare December 5, 2024 21:21
chainchad
chainchad reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@chainchad chainchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- only comment would be to run tests/build in a CI workflow and to confirm that the dist/ output is the same as what our build created.

apps/go-test-caching/README.md Outdated Show resolved Hide resolved
@erikburt erikburt enabled auto-merge (squash) December 6, 2024 21:11
@erikburt erikburt merged commit 9a266f6 into main Dec 6, 2024
11 checks passed
@erikburt erikburt deleted the feat/go-test-binary-comparison branch December 6, 2024 21:12
@app-token-issuer-releng-renovate app-token-issuer-releng-renovate bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebawo sebawo sebawo left review comments

@jmank88 jmank88 jmank88 left review comments

@chainchad chainchad chainchad approved these changes

Assignees

@erikburt erikburt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikburt @jmank88 @sebawo @chainchad