Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin version for push-gha-metrics-action #25

Merged
merged 1 commit into from
Nov 6, 2023
Merged

pin version for push-gha-metrics-action #25

merged 1 commit into from
Nov 6, 2023

Conversation

momentmaker
Copy link
Contributor

No description provided.

@momentmaker momentmaker requested a review from a team as a code owner November 4, 2023 15:42
@momentmaker momentmaker mentioned this pull request Nov 4, 2023
Closed
1 task
erikburt
erikburt approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@erikburt erikburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's some potentially nefarious whitespace changes., otherwise LGTM

@momentmaker
Copy link
Contributor Author

I'm using actionlint which lints github actions. It should be good right?

@erikburt
Copy link
Contributor

erikburt commented Nov 6, 2023

I'm using actionlint which lints github actions. It should be good right?

I'm not really sure, it seems like a widely used tool so very unlikely it actually breaks anything.

@momentmaker
Copy link
Contributor Author

if break then destroy actionlint

@momentmaker momentmaker merged commit 9450424 into main Nov 6, 2023
5 checks passed
@momentmaker momentmaker deleted the chore/pin-version-push-gha-metrics-action branch November 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikburt erikburt erikburt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momentmaker @erikburt