SMK-1394: Infinite loop on close connection #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is affecting consumers when it takes more than 2*heartbeat time to process a message. When trying to close the connection, library will: * check the heartbeat * detect that it passed more than 2*times the heartbeat value without receiving anything * considers that server has gone away and tries to reconnect * after reconnecting as it is not clearing internal variables with time of last read, it will check the heartbeat again and try to reconnect again in loop. There are already issues on the library's github: php-amqplib#309 and php-amqplib#413
escudeiro
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is affecting consumers when it takes more than 2*heartbeat time to process a message.
When trying to close the connection, library will:
There are already issues on the library's github: php-amqplib#309 and php-amqplib#413
cc @smarkio/developers