Rename newDistinguisedNames to newExtraNames

smallstep · May 17, 2022 · c93d3e3 · c93d3e3
1 parent 005d309
commit c93d3e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/x509util/name.go b/x509util/name.go
@@ -53,7 +53,7 @@ func newName(n pkix.Name) Name {
 		PostalCode:         n.PostalCode,
 		SerialNumber:       n.SerialNumber,
 		CommonName:         n.CommonName,
-		ExtraNames:         newDistinguisedNames(n.Names),
+		ExtraNames:         newExtraNames(n.Names),
 	}
 }
 
@@ -149,9 +149,9 @@ type DistinguishedName struct {
 	Value interface{}      `json:"value"`
 }
 
-// newDistinguisedNames returns a list of DistinguishedName with the attributes not
+// newExtraNames returns a list of DistinguishedName with the attributes not
 // present in attributeTypeNames.
-func newDistinguisedNames(atvs []pkix.AttributeTypeAndValue) []DistinguishedName {
+func newExtraNames(atvs []pkix.AttributeTypeAndValue) []DistinguishedName {
 	var extraNames []DistinguishedName
 	for _, atv := range atvs {
 		if _, ok := attributeTypeNames[atv.Type.String()]; !ok {

diff --git a/x509util/name_test.go b/x509util/name_test.go
@@ -455,7 +455,7 @@ func TestIssuer_Set(t *testing.T) {
 	}
 }
 
-func Test_newDistinguisedNames(t *testing.T) {
+func Test_newExtraNames(t *testing.T) {
 	type args struct {
 		atvs []pkix.AttributeTypeAndValue
 	}
@@ -476,7 +476,7 @@ func Test_newDistinguisedNames(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if got := newDistinguisedNames(tt.args.atvs); !reflect.DeepEqual(got, tt.want) {
+			if got := newExtraNames(tt.args.atvs); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("newDistinguisedNames() = %v, want %v", got, tt.want)
 			}
 		})