Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca.NewClient don't allow setting a timeout for the http client #2176

Open
RangelReale opened this issue Feb 17, 2025 · 0 comments · May be fixed by #2191
Open

ca.NewClient don't allow setting a timeout for the http client #2176

RangelReale opened this issue Feb 17, 2025 · 0 comments · May be fixed by #2191
Assignees
@maraino
Labels
enhancement needs triage Waiting for discussion / prioritization by team

Comments

@RangelReale
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

ca.NewClient don't allow setting a timeout for the http client.

Why is this needed?

If an http client don't have a timeout, it can potentially wait forever, setting one is a common best practice.

But the client in the ca don't don't provide any way of setting it.
@RangelReale RangelReale added enhancement needs triage Waiting for discussion / prioritization by team labels Feb 17, 2025
maraino added a commit that referenced this issue Feb 25, 2025
@maraino
Add option to specify a client timeout
5ea0d89 
This commit adds to the ca Client a new option to specify the client
timeout.

Fixes #2176
@maraino maraino linked a pull request Feb 25, 2025 that will close this issue
Open
maraino added a commit that referenced this issue Feb 25, 2025
@maraino
Add option to specify a client timeout
f5425ff 
This commit adds to the ca Client a new option to specify the client
timeout.

Fixes #2176
maraino added a commit that referenced this issue Feb 25, 2025
@maraino
Add option to specify a client timeout
1a05f48 
This commit adds to the ca Client a new option to specify the client
timeout.

Fixes #2176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraino maraino

Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to specify a client timeout smallstep/certificates
2 participants
@RangelReale @maraino