fix: Inbound and outbound reference #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holomekc thanks for this, it looks good to me! |
ozangunalp
approved these changes
Mar 10, 2025
|
@holomekc would it be possible to sign your commits? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
holomekc
force-pushed
the
fix/inbound-outbound-reference
branch
2 times, most recently
from
e1f8080 to
6ac3ded
Compare
When using a static variable it can lead to strange behavior in tests. E.g. two health check test based on the same direction would create melon tests.
holomekc
force-pushed
the
fix/inbound-outbound-reference
branch
from
6ac3ded to
abbb758
Compare
|
Sure. Is signed now |
|
Hi @ozangunalp, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a static variable it can lead to strange behavior in tests. E.g. two health check test based on the same direction would create melon tests.
I noticed that while working on the sns connector. I think static is not needed anyway the bean is applicationScoped