Ensure JAX-RS Request Body is properly handled when non JAX-RS annotations present #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix, the implementation would disregard a proper JAX-RS request body parameter if it was annotated with any annotation, like for example javax.validation.Valid
geoand
changed the title
geoand
changed the title
|
Does this also fix #90 ? |
|
I hadn't seen that issue at all! It seems exactly the same as the Quarkus one which I tested against with this patch (and reference in the description) , so I would say yes, it does. |
kenfinnigan
approved these changes
May 5, 2019
|
Thanks! Would it be possible to get a new release so we can include it in Quarkus and close a couple related issues that people are having? Thanks again |
|
We should make sure to get #97 merged as well - before doing a release. @kenfinnigan |
|
@kenfinnigan I've merged both outstanding PRs - if you can kick off a release. Should it be a standard release or a snapshot release? Not sure what we support here. Doesn't matter to me! :) |
|
I've kicked off a release build |
gasper-vrhovsek
pushed a commit
to gasper-vrhovsek/smallrye-open-api
that referenced
this pull request
May 17, 2021
…lrye.config-smallrye-config-1.8.5 Bump smallrye-config from 1.8.1 to 1.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, the implementation would disregard a proper JAX-RS
request body parameter if it was annotated with any annotation, like for
example
javax.validation.ValidRelates to: quarkusio/quarkus#2339
cc @kenfinnigan