Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden schema properties, add support for JSON-B name override #91

Merged

Conversation

MikeEdgar
Copy link
Member

This addresses #89 and also adds support for overriding property names by considering the value of @JsonbProperty annotations. I'm not sure if that has specification impacts, but I at least wanted to get that discussion started here.

  • Add support for properties to be hidden using @Schema or @JsonbTransient
  • Add support for property key names to consider value of @JsonbProperty value attribute
  • Test cases

* Add support for properties to be hidden using @Schema or
@JsonbTransient
* Add support for property key names to consider value of @JsonbProperty
value attribute
* Test cases
Copy link
Contributor

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thorough tests. +1 from me.

@kenfinnigan kenfinnigan merged commit 76504fa into smallrye:master Apr 30, 2019
@MikeEdgar MikeEdgar deleted the schema_hidden_fields_custom_names branch May 1, 2019 12:50
gasper-vrhovsek pushed a commit to gasper-vrhovsek/smallrye-open-api that referenced this pull request May 17, 2021
…-assured-rest-assured-4.3.1

Bump rest-assured from 4.3.0 to 4.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants