Update log messages that indicate wrong config values from FINER to W…

…ARNING
smallrye · Oct 11, 2023 · 0136263 · 0136263
1 parent 339f90d
commit 0136263
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 41 deletions.
diff --git a/...entation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketConfiguration.java b/...entation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketConfiguration.java
@@ -49,12 +49,10 @@ public static Collection<HistogramBucketConfiguration> parse(String input) {
                             if (s.matches("[0-9]+[.]*[0-9]*")) {
                                 return Double.parseDouble(s);
                             } else {
-                                if (LOGGER.isLoggable(Level.FINER)) {
-                                    LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                            "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
-                                                    + "and decimal values are accepted.",
-                                            new Object[] { s, MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
-                                }
+                                LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                                        "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
+                                                + "and decimal values are accepted.",
+                                        new Object[] { s, MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
                                 return null;
                             }
                         }).filter(x -> x != null).toArray(Double[]::new);

diff --git a/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMaxConfiguration.java b/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMaxConfiguration.java
@@ -40,12 +40,10 @@ public static Collection<HistogramBucketMaxConfiguration> parse(String input) {
                     Double value = Double.parseDouble(keyValueSplit[1].trim());
                     metricBucketConfiguration = new HistogramBucketMaxConfiguration(metricName, value);
                 } else {
-                    if (LOGGER.isLoggable(Level.FINER)) {
-                        LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
-                                        + "and decimal values are accepted.",
-                                new Object[] { keyValueSplit[1], MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
-                    }
+                    LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                            "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
+                                    + "and decimal values are accepted.",
+                            new Object[] { keyValueSplit[1], MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
                 }
             } else {
                 //either no value.. or too many values

diff --git a/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMinConfiguration.java b/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMinConfiguration.java
@@ -40,12 +40,10 @@ public static Collection<HistogramBucketMinConfiguration> parse(String input) {
                     Double value = Double.parseDouble(keyValueSplit[1].trim());
                     metricBucketConfiguration = new HistogramBucketMinConfiguration(metricName, value);
                 } else {
-                    if (LOGGER.isLoggable(Level.FINER)) {
-                        LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
-                                        + "and decimal values are accepted.",
-                                new Object[] { keyValueSplit[1], MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
-                    }
+                    LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                            "The value \"{0}\" is invalid for the \"{1}\" property. Only integer "
+                                    + "and decimal values are accepted.",
+                            new Object[] { keyValueSplit[1], MetricsConfigurationManager.MP_HISTOGRAM_BUCKET_PROP });
                 }
             } else {
                 //either no value.. or too many values through improper syntax

diff --git a/...ntation/src/main/java/io/smallrye/metrics/setup/config/MetricPercentileConfiguration.java b/...ntation/src/main/java/io/smallrye/metrics/setup/config/MetricPercentileConfiguration.java
@@ -67,11 +67,9 @@ public static Collection<MetricPercentileConfiguration> parseMetricPercentiles(S
                     if (s.matches("[0][.][0-9]+")) {
                         return Double.parseDouble(s);
                     } else {
-                        if (LOGGER.isLoggable(Level.FINER)) {
-                            LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                    "The value \"{0}\" is invalid for the \"{1}\" property. Only values 0.0-1.0 inclusively are accepted.",
-                                    new Object[] { s, MetricsConfigurationManager.MP_PERCENTILES_PROP });
-                        }
+                        LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                                "The value \"{0}\" is invalid for the \"{1}\" property. Only values 0.0-1.0 inclusively are accepted.",
+                                new Object[] { s, MetricsConfigurationManager.MP_PERCENTILES_PROP });
                         return null;
                     }
 

diff --git a/implementation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketConfiguration.java b/implementation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketConfiguration.java
@@ -58,12 +58,10 @@ public static Collection<TimerBucketConfiguration> parse(String input) {
                     } else if (s.matches("[0-9]+")) {
                         return Duration.ofMillis(Long.parseLong(s));
                     } else {
-                        if (LOGGER.isLoggable(Level.FINER)) {
-                            LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                    "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
-                                            + "optional time unit (e.g. ms,s,m,h) are accepted.",
-                                    new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
-                        }
+                        LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                                "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
+                                        + "optional time unit (e.g. ms,s,m,h) are accepted.",
+                                new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
                         return null;
                     }
                 }).filter(s -> s != null).toArray(Duration[]::new);

diff --git a/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMaxConfiguration.java b/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMaxConfiguration.java
@@ -55,12 +55,10 @@ public static Collection<TimerBucketMaxConfiguration> parse(String input) {
                 } else if (s.matches("[0-9]+")) {
                     dur = Duration.ofMillis(Long.parseLong(s));
                 } else {
-                    if (LOGGER.isLoggable(Level.FINER)) {
-                        LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
-                                        + "optional time unit (e.g. ms,s,m,h) are accepted.",
-                                new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
-                    }
+                    LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                            "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
+                                    + "optional time unit (e.g. ms,s,m,h) are accepted.",
+                            new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
                 }
 
             } else {

diff --git a/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMinConfiguration.java b/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMinConfiguration.java
@@ -55,12 +55,10 @@ public static Collection<TimerBucketMinConfiguration> parse(String input) {
                 } else if (s.matches("[0-9]+")) {
                     dur = Duration.ofMillis(Long.parseLong(s));
                 } else {
-                    if (LOGGER.isLoggable(Level.FINER)) {
-                        LOGGER.logp(Level.FINER, CLASS_NAME, null,
-                                "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
-                                        + "optional time unit (e.g. ms,s,m,h) are accepted.",
-                                new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
-                    }
+                    LOGGER.logp(Level.WARNING, CLASS_NAME, null,
+                            "The value \"{0}\" is invalid for the \"{1}\" property. Only integer values with an "
+                                    + "optional time unit (e.g. ms,s,m,h) are accepted.",
+                            new Object[] { s, MetricsConfigurationManager.MP_TIMER_BUCKET_PROP });
                 }
 
             } else {