Fix assert-crash due to excessive scores length #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For searches that hit multiple mailboxes (virtual mailboxes is an easy way to force a multisearch), an assert-crash will happen if a message matches both the main query and internal "maybe" queries. Fix by ensuring that scores are only added once per UID. This was broken in single mailbox search as well, but it was ignored there as there was no assert check on scores length (the extra entries were ignored during processing). In order to calcuate scores correctly (now that we are only adding them once), refactor result iteration to only run the maybe query once for all maybe queries. Add the main query to this query for score calculation purposes. This is a bit of an optimization, so nice. Fixes GitHub Issue #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For searches that hit multiple mailboxes (virtual mailboxes is an easy way to force a multisearch), an assert-crash will happen if a message matches both the main query and internal "maybe" queries.
Fix by ensuring that scores are only added once per UID.
This was broken in single mailbox search as well, but it was ignored there as there was no assert check on scores length (the extra entries were ignored during processing).
In order to calcuate scores correctly (now that we are only adding them once), refactor result iteration to only run the maybe query once for all maybe queries. Add the main query to this query for score calculation purposes. This is a bit of an optimization, so nice.
Fixes GitHub Issue #61