Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: source-track: rename SCP to SCS, replace issue links with project board links. #1171

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

zachariahcox
Copy link
Contributor

@zachariahcox zachariahcox commented Oct 1, 2024

fixes: #1128

(cleaned up version of #1166)

This change is in response to the 9.30 slsa specification meeting on this topic.

A SCS is the full suite of services and ideas relied upon by the organization to create source revisions.

VCS stuff should mostly fall out of the discussion

Repositories can be used as the concept used when we need to talk about authN and authZ w.r.t. authentic contributions.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit eefe9d9
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66fdaac08cd21400077e8cc5
😎 Deploy Preview https://deploy-preview-1171--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adityasaky adityasaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I have one suggestion to broaden the definition of the SCS.

docs/spec/draft/source-requirements.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@TomHennen TomHennen requested a review from mlieberman85 October 2, 2024 21:17
Copy link
Member

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomHennen TomHennen changed the title content: source-track: rename SCP to SCS, replace issue links with project board links. content: draft: source-track: rename SCP to SCS, replace issue links with project board links. Oct 2, 2024
@TomHennen
Copy link
Contributor

Two maintainers seems good enough for a draft.

Note: I've updated the title to indicate this is a draft.

@TomHennen TomHennen merged commit d70bc35 into slsa-framework:main Oct 2, 2024
8 checks passed
TomHennen added a commit to TomHennen/slsa that referenced this pull request Oct 16, 2024
In PR slsa-framework#1171 we replaced 'Source Control Platform' with
'Source Control System'.  It looks like we missed a 'Platform'
usage.  This replaces that last 'Platform' with 'System'

Signed-off-by: Tom Hennen <tomhennen@google.com>
TomHennen added a commit that referenced this pull request Oct 16, 2024
In PR #1171 we replaced 'Source Control Platform' with 'Source Control
System'. It looks like we missed a 'Platform' usage. This replaces that
last 'Platform' with 'System'

Signed-off-by: Tom Hennen <tomhennen@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Define 'source control system' in source track
5 participants