Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GitHub token optional #324

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Make GitHub token optional #324

merged 1 commit into from
Oct 25, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon
Make GitHub token optional
a0c774b 
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@laurentsimon laurentsimon requested review from kpk47 and asraa October 25, 2022 10:55
@laurentsimon
Copy link
Contributor Author

@kpk47 I think it's fine to make the token optional, correct?

@laurentsimon laurentsimon enabled auto-merge (squash) October 25, 2022 10:55
@laurentsimon laurentsimon merged commit e9e3ab2 into main Oct 25, 2022
@kpk47
Copy link
Contributor

kpk47 commented Oct 25, 2022

The Action makes a GitHub API call, so I think you'll get a 403 if you don't pass the token.

@laurentsimon
Copy link
Contributor Author

There is a default: ${{ github.token }} even if the argument is optional.

@kpk47
Copy link
Contributor

kpk47 commented Oct 25, 2022

Oh, right. My mistake.

@ianlewis ianlewis deleted the laurentsimon-patch-7 branch August 6, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentsimon @kpk47 @asraa